Commit f2e3d0d7 authored by Beleswar Padhi's avatar Beleswar Padhi Committed by Mathieu Poirier
Browse files

remoteproc: k3-r5: Use devm_kcalloc() helper 



Use a device lifecycle managed action to free memory. This helps prevent
mistakes like freeing out of order in cleanup functions and forgetting
to free on error paths.

Signed-off-by: default avatarBeleswar Padhi <b-padhi@ti.com>
Reviewed-by: default avatarAndrew Davis <afd@ti.com>
Link: https://lore.kernel.org/r/20241219110545.1898883-3-b-padhi@ti.com


Signed-off-by: default avatarMathieu Poirier <mathieu.poirier@linaro.org>
parent 972361e3

drivers/remoteproc/ti_k3_r5_remoteproc.c

+1 −3
Original line number Diff line number Diff line
@@ -997,7 +997,7 @@ static int k3_r5_reserved_mem_init(struct k3_r5_rproc *kproc) 
		return ret;



	num_rmems--;

	kproc->rmem = kcalloc(num_rmems, sizeof(*kproc->rmem), GFP_KERNEL);

	kproc->rmem = devm_kcalloc(dev, num_rmems, sizeof(*kproc->rmem), GFP_KERNEL);

	if (!kproc->rmem)

		return -ENOMEM;
@@ -1049,7 +1049,6 @@ static int k3_r5_reserved_mem_init(struct k3_r5_rproc *kproc) 
unmap_rmem:

	for (i--; i >= 0; i--)

		iounmap(kproc->rmem[i].cpu_addr);

	kfree(kproc->rmem);

	return ret;

}
@@ -1059,7 +1058,6 @@ static void k3_r5_reserved_mem_exit(struct k3_r5_rproc *kproc) 


	for (i = 0; i < kproc->num_rmems; i++)

		iounmap(kproc->rmem[i].cpu_addr);

	kfree(kproc->rmem);

}



/*