Commit f2ec9856 authored by Christian Marangi's avatar Christian Marangi Committed by David S. Miller
Browse files

net: phy: qcom: qca808x: fix logic error in LED brightness set 



In switching to using phy_modify_mmd and a more short version of the
LED ON/OFF condition in later revision, it was made a logic error where

value ? QCA808X_LED_FORCE_ON : QCA808X_LED_FORCE_OFF is always true as
value is always OR with QCA808X_LED_FORCE_EN due to missing ()
resulting in the testing condition being QCA808X_LED_FORCE_EN | value.

Add the () to apply the correct condition and restore correct
functionality of the brightness ON/OFF.

Fixes: 7196062b ("net: phy: at803x: add LED support for qca808x")
Signed-off-by: default avatarChristian Marangi <ansuelsmth@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 0eb1ec42

drivers/net/phy/qcom/qca808x.c

+2 −2
Original line number Diff line number Diff line
@@ -820,8 +820,8 @@ static int qca808x_led_brightness_set(struct phy_device *phydev, 


	return phy_modify_mmd(phydev, MDIO_MMD_AN, reg,

			      QCA808X_LED_FORCE_EN | QCA808X_LED_FORCE_MODE_MASK,

			      QCA808X_LED_FORCE_EN | value ? QCA808X_LED_FORCE_ON :

							     QCA808X_LED_FORCE_OFF);

			      QCA808X_LED_FORCE_EN | (value ? QCA808X_LED_FORCE_ON :

							     QCA808X_LED_FORCE_OFF));

}



static int qca808x_led_blink_set(struct phy_device *phydev, u8 index,