Commit f3616173 authored by Zhipeng Lu's avatar Zhipeng Lu Committed by David S. Miller
Browse files

atm: idt77252: fix a memleak in open_card_ubr0 



When alloc_scq fails, card->vcs[0] (i.e. vc) should be freed. Otherwise,
in the following call chain:

idt77252_init_one
  |-> idt77252_dev_open
        |-> open_card_ubr0
              |-> alloc_scq [failed]
  |-> deinit_card
        |-> vfree(card->vcs);

card->vcs is freed and card->vcs[0] is leaked.

Fixes: 1da177e4 ("Linux-2.6.12-rc2")
Signed-off-by: default avatarZhipeng Lu <alexious@zju.edu.cn>
Reviewed-by: default avatarJiri Pirko <jiri@nvidia.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent d75abeec

drivers/atm/idt77252.c

+2 −0
Original line number Diff line number Diff line
@@ -2930,6 +2930,8 @@ open_card_ubr0(struct idt77252_dev *card) 
	vc->scq = alloc_scq(card, vc->class);

	if (!vc->scq) {

		printk("%s: can't get SCQ.\n", card->name);

		kfree(card->vcs[0]);

		card->vcs[0] = NULL;

		return -ENOMEM;

	}