Commit f36ba810 authored by Wei Yang's avatar Wei Yang Committed by Andrew Morton
Browse files

maple_tree: remove maple_big_node.parent 

Patch series "Reduce the space to be cleared for maple_big_node", v2.

Found current code may clear maple_big_node redundantly.

First we define a field parent, which is never used.  After removing this,
we reduce the size of memory to be cleared by memset.

Then mast_fill_bnode() clears part of the structure twice, since slot and
gap share some space.  By clearing the whole structure, we can avoid this.


This patch (of 2):

The member parent of maple_big_node is never used.

Let's remove it which could reduce the number of space to be cleared on
memset.

Link: https://lkml.kernel.org/r/20240908140554.20378-1-richard.weiyang@gmail.com
Link: https://lkml.kernel.org/r/20240908140554.20378-2-richard.weiyang@gmail.com


Signed-off-by: default avatarWei Yang <richard.weiyang@gmail.com>
Reviewed-by: default avatarLiam R. Howlett <Liam.Howlett@Oracle.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent 1c148069

lib/maple_tree.c

+0 −1
Original line number Diff line number Diff line
@@ -120,7 +120,6 @@ static const unsigned char mt_min_slots[] = { 
#define MAPLE_BIG_NODE_GAPS	(MAPLE_ARANGE64_SLOTS * 2 + 1)



struct maple_big_node {

	struct maple_pnode *parent;

	unsigned long pivot[MAPLE_BIG_NODE_SLOTS - 1];

	union {

		struct maple_enode *slot[MAPLE_BIG_NODE_SLOTS];