Commit f3e1dccb authored by Frank Li's avatar Frank Li Committed by Bjorn Helgaas
Browse files

PCI: dwc: ep: Ensure proper iteration over outbound map windows 

Most systems' PCIe outbound map windows have non-zero physical addresses,
but the possibility of encountering zero increased after following commit
("PCI: dwc: Use parent_bus_offset").

'ep->outbound_addr[n]', representing 'parent_bus_address', might be 0 on
some hardware, which trims high address bits through bus fabric before
sending to the PCIe controller.

Replace the iteration logic with 'for_each_set_bit()' to ensure only
allocated map windows are iterated when determining the ATU index from a
given address.

Link: https://lore.kernel.org/r/20250315201548.858189-12-helgaas@kernel.org


Signed-off-by: default avatarFrank Li <Frank.Li@nxp.com>
Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
parent f28b3c9c

drivers/pci/controller/dwc/pcie-designware-ep.c

+1 −1
Original line number Diff line number Diff line
@@ -282,7 +282,7 @@ static int dw_pcie_find_index(struct dw_pcie_ep *ep, phys_addr_t addr, 
	u32 index;

	struct dw_pcie *pci = to_dw_pcie_from_ep(ep);



	for (index = 0; index < pci->num_ob_windows; index++) {

	for_each_set_bit(index, ep->ob_window_map, pci->num_ob_windows) {

		if (ep->outbound_addr[index] != addr)

			continue;

		*atu_index = index;