Commit f42fa178 authored by Kent Overstreet's avatar Kent Overstreet
Browse files

bcachefs: Fix missing transaction commit 



In may_delete_deleted_inode(), there's a corner case when a snapshot was
taken while we had an unlinked inode: we don't want to delete the inode
in the internal (shared) snapshot node, since it might have been
reattached in a descendent snapshot.

Instead we propagate the key to any snapshot leaves it doesn't exist in,
so that it can be deleted there if necessary, and then clear the
unlinked flag in the internal node.

But we forgot to commit after clearing the unlinked flag, causing us to
go into an infinite loop.

Signed-off-by: default avatarKent Overstreet <kent.overstreet@linux.dev>
parent 178c4873

fs/bcachefs/inode.c

+4 −2
Original line number Diff line number Diff line
@@ -1169,8 +1169,10 @@ int bch2_delete_dead_inodes(struct bch_fs *c) 
	 */

	for_each_btree_key(trans, iter, BTREE_ID_deleted_inodes, POS_MIN,

			   BTREE_ITER_PREFETCH|BTREE_ITER_ALL_SNAPSHOTS, k, ret) {

		ret = lockrestart_do(trans, may_delete_deleted_inode(trans, &iter, k.k->p,

								     &need_another_pass));

		ret = commit_do(trans, NULL, NULL,

				BTREE_INSERT_NOFAIL|

				BTREE_INSERT_LAZY_RW,

			may_delete_deleted_inode(trans, &iter, k.k->p, &need_another_pass));

		if (ret < 0)

			break;