Commit f54cd8f4 authored by James Clark's avatar James Clark Committed by Namhyung Kim
Browse files

perf test: Don't signal all processes on system when interrupting tests 



This signal handler loops over all tests on ctrl-C, but it's active
while the test list is being constructed. process.pid is 0, then -1,
then finally set to the child pid on fork. If the Ctrl-C is received
during this point a kill(-1, SIGINT) can be sent which affects all
processes.

Make sure the child has forked first before forwarding the signal. This
can be reproduced with ctrl-C immediately after launching perf test
which terminates the ssh connection.

Fixes: 553d5efe ("perf test: Add a signal handler to kill forked child processes")
Signed-off-by: default avatarJames Clark <james.clark@linaro.org>
Reviewed-by: default avatarIan Rogers <irogers@google.com>
Link: https://lore.kernel.org/r/20241129151948.3199732-1-james.clark@linaro.org


Signed-off-by: default avatarNamhyung Kim <namhyung@kernel.org>
parent 23c44f6c

tools/perf/tests/builtin-test.c

+1 −1
Original line number Diff line number Diff line
@@ -508,7 +508,7 @@ static int __cmd_test(struct test_suite **suites, int argc, const char *argv[], 
		for (size_t x = 0; x < num_tests; x++) {

			struct child_test *child_test = child_tests[x];



			if (!child_test)

			if (!child_test || child_test->process.pid <= 0)

				continue;



			pr_debug3("Killing %d pid %d\n",