Unverified Commit f57869b7 authored by Mark Hasemeyer's avatar Mark Hasemeyer Committed by AngeloGioacchino Del Regno
Browse files

arm64: dts: mediatek: mt8183: Enable cros-ec-spi as wake source 



The cros_ec driver currently assumes that cros-ec-spi compatible device
nodes are a wakeup-source even though the wakeup-source property is not
defined.

Some Chromebooks use a separate wake pin, while others overload the
interrupt for wake and IO. With the current assumption, spurious wakes
can occur on systems that use a separate wake pin. It is planned to
update the driver to no longer assume that the EC interrupt pin should
be enabled for wake.

Add the wakeup-source property to all cros-ec-spi compatible device
nodes to signify to the driver that they should still be a valid wakeup
source.

Signed-off-by: default avatarMark Hasemeyer <markhas@chromium.org>
Reviewed-by: default avatarAngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Link: https://lore.kernel.org/r/20240102140734.v4.10.Iba4a8b7e908989e57f7838a80013a4062be5e614@changeid


Signed-off-by: default avatarMatthias Brugger <matthias.bgg@gmail.com>
Signed-off-by: default avatarAngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
parent 89954fe8

arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi

+1 −0
Original line number Diff line number Diff line
@@ -924,6 +924,7 @@ cros_ec: cros-ec@0 { 
		interrupts-extended = <&pio 151 IRQ_TYPE_LEVEL_LOW>;

		pinctrl-names = "default";

		pinctrl-0 = <&ec_ap_int_odl>;

		wakeup-source;



		i2c_tunnel: i2c-tunnel {

			compatible = "google,cros-ec-i2c-tunnel";