Commit f584e375 authored by Hongbo Li's avatar Hongbo Li Committed by Julia Lawall
Browse files

coccinelle: Remove unnecessary parentheses for only one possible change. 



The parentheses are only needed if there is a disjunction, ie a
set of possible changes. If there is only one pattern, we can
remove these parentheses. Just like the format:

  -  x
  +  y

not:

  (
  -  x
  +  y
  )

Signed-off-by: default avatarHongbo Li <lihongbo22@huawei.com>
Signed-off-by: default avatarJulia Lawall <Julia.Lawall@inria.fr>
parent 253244cd

scripts/coccinelle/api/string_choices.cocci

+0 −8
Original line number Diff line number Diff line
@@ -43,18 +43,14 @@ coccilib.report.print_report(p[0], "opportunity for str_plural(%s)" % e) 
@str_up_down depends on patch@

expression E;

@@

(

-	((E) ? "up" : "down")

+	str_up_down(E)

)



@str_up_down_r depends on !patch exists@

expression E;

position P;

@@

(

*	((E@P) ? "up" : "down")

)



@script:python depends on report@

p << str_up_down_r.P;
@@ -66,18 +62,14 @@ coccilib.report.print_report(p[0], "opportunity for str_up_down(%s)" % e) 
@str_down_up depends on patch@

expression E;

@@

(

-      ((E) ? "down" : "up")

+      str_down_up(E)

)



@str_down_up_r depends on !patch exists@

expression E;

position P;

@@

(

*      ((E@P) ? "down" : "up")

)



@script:python depends on report@

p << str_down_up_r.P;