Commit f5b30c7f authored by Jinjie Ruan's avatar Jinjie Ruan Committed by Miquel Raynal
Browse files

mtd: rawnand: stm32_fmc2: Use for_each_child_of_node_scoped() 



Avoids the need for manual cleanup of_node_put() in early exits
from the loop.

Signed-off-by: default avatarJinjie Ruan <ruanjinjie@huawei.com>
Signed-off-by: default avatarMiquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/linux-mtd/20240826094328.2991664-10-ruanjinjie@huawei.com
parent f3b3c47c

drivers/mtd/nand/raw/stm32_fmc2_nand.c

+2 −5
Original line number Diff line number Diff line
@@ -1851,7 +1851,6 @@ static int stm32_fmc2_nfc_parse_child(struct stm32_fmc2_nfc *nfc, 
static int stm32_fmc2_nfc_parse_dt(struct stm32_fmc2_nfc *nfc)

{

	struct device_node *dn = nfc->dev->of_node;

	struct device_node *child;

	int nchips = of_get_child_count(dn);

	int ret = 0;
@@ -1865,13 +1864,11 @@ static int stm32_fmc2_nfc_parse_dt(struct stm32_fmc2_nfc *nfc) 
		return -EINVAL;

	}



	for_each_child_of_node(dn, child) {

	for_each_child_of_node_scoped(dn, child) {

		ret = stm32_fmc2_nfc_parse_child(nfc, child);

		if (ret < 0) {

			of_node_put(child);

		if (ret < 0)

			return ret;

	}

	}



	return ret;

}