Commit f5b6b463 authored by Thorsten Blum's avatar Thorsten Blum Committed by Leon Romanovsky
Browse files

RDMA/bnxt_re: Call strscpy() with correct size argument 



In bnxt_re_register_ib(), strscpy() is called with the length of the
source string rather than the size of the destination buffer.

This is fine as long as the destination buffer is larger than the source
string, but we should still use the destination buffer size instead to
call strscpy() as intended. And since 'node_desc' has a fixed size, we
can safely omit the size argument and let strscpy() infer it using
sizeof().

Signed-off-by: default avatarThorsten Blum <thorsten.blum@linux.dev>
Link: https://patch.msgid.link/20250901150038.227036-2-thorsten.blum@linux.dev


Signed-off-by: default avatarLeon Romanovsky <leon@kernel.org>
parent 2ed096dc

drivers/infiniband/hw/bnxt_re/main.c

+1 −2
Original line number Diff line number Diff line
@@ -1383,8 +1383,7 @@ static int bnxt_re_register_ib(struct bnxt_re_dev *rdev) 


	/* ib device init */

	ibdev->node_type = RDMA_NODE_IB_CA;

	strscpy(ibdev->node_desc, BNXT_RE_DESC " HCA",

		strlen(BNXT_RE_DESC) + 5);

	strscpy(ibdev->node_desc, BNXT_RE_DESC " HCA");

	ibdev->phys_port_cnt = 1;



	addrconf_addr_eui48((u8 *)&ibdev->node_guid, rdev->netdev->dev_addr);