Commit f63a9dc5 authored by Asbjørn Sloth Tønnesen's avatar Asbjørn Sloth Tønnesen Committed by Jakub Kicinski
Browse files

net: qede: use extack in qede_set_v4_tuple_to_profile() 



Convert qede_set_v4_tuple_to_profile() to take extack,
and drop the edev argument.

Convert DP_INFO call to use NL_SET_ERR_MSG_MOD instead.

In calls to qede_set_v4_tuple_to_profile(), use NULL as extack
for now, until a subsequent patch makes extack available.

Only compile tested.

Signed-off-by: default avatarAsbjørn Sloth Tønnesen <ast@fiberby.net>
Reviewed-by: default avatarSimon Horman <horms@kernel.org>
Link: https://lore.kernel.org/r/20240508143404.95901-4-ast@fiberby.net


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 6f88f125

drivers/net/ethernet/qlogic/qede/qede_filter.c

+4 −4
Original line number Diff line number Diff line
@@ -1520,8 +1520,8 @@ static int qede_flow_spec_validate_unused(struct qede_dev *edev, 
	return 0;

}



static int qede_set_v4_tuple_to_profile(struct qede_dev *edev,

					struct qede_arfs_tuple *t)

static int qede_set_v4_tuple_to_profile(struct qede_arfs_tuple *t,

					struct netlink_ext_ack *extack)

{

	/* We must have Only 4-tuples/l4 port/src ip/dst ip

	 * as an input.
@@ -1538,7 +1538,7 @@ static int qede_set_v4_tuple_to_profile(struct qede_dev *edev, 
		   t->dst_ipv4 && !t->src_ipv4) {

		t->mode = QED_FILTER_CONFIG_MODE_IP_DEST;

	} else {

		DP_INFO(edev, "Invalid N-tuple\n");

		NL_SET_ERR_MSG_MOD(extack, "Invalid N-tuple");

		return -EOPNOTSUPP;

	}
@@ -1779,7 +1779,7 @@ qede_flow_parse_v4_common(struct qede_dev *edev, struct flow_rule *rule, 
	if (err)

		return err;



	return qede_set_v4_tuple_to_profile(edev, t);

	return qede_set_v4_tuple_to_profile(t, NULL);

}



static int