Commit f6d7695b authored by Paolo Abeni's avatar Paolo Abeni
Browse files

ipmr: fix build with clang and DEBUG_NET disabled. 



Sasha reported a build issue in ipmr::

net/ipv4/ipmr.c:320:13: error: function 'ipmr_can_free_table' is not \
	needed and will not be emitted \
	[-Werror,-Wunneeded-internal-declaration]
   320 | static bool ipmr_can_free_table(struct net *net)

Apparently clang is too smart with BUILD_BUG_ON_INVALID(), let's
fallback to a plain WARN_ON_ONCE().

Reported-by: default avatarSasha Levin <sashal@kernel.org>
Closes: https://qa-reports.linaro.org/lkft/sashal-linus-next/build/v6.11-25635-g6813e2326f1e/testrun/26111580/suite/build/test/clang-nightly-lkftconfig/details/


Fixes: 11b6e701 ("ipmr: add debug check for mr table cleanup")
Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
Link: https://patch.msgid.link/ee75faa926b2446b8302ee5fc30e129d2df73b90.1732810228.git.pabeni@redhat.com


Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
parent 04f5cb48

net/ipv4/ipmr.c

+1 −1
Original line number Diff line number Diff line
@@ -437,7 +437,7 @@ static void ipmr_free_table(struct mr_table *mrt) 
{

	struct net *net = read_pnet(&mrt->net);



	DEBUG_NET_WARN_ON_ONCE(!ipmr_can_free_table(net));

	WARN_ON_ONCE(!ipmr_can_free_table(net));



	timer_shutdown_sync(&mrt->ipmr_expire_timer);

	mroute_clean_tables(mrt, MRT_FLUSH_VIFS | MRT_FLUSH_VIFS_STATIC |

net/ipv6/ip6mr.c

+1 −1
Original line number Diff line number Diff line
@@ -416,7 +416,7 @@ static void ip6mr_free_table(struct mr_table *mrt) 
{

	struct net *net = read_pnet(&mrt->net);



	DEBUG_NET_WARN_ON_ONCE(!ip6mr_can_free_table(net));

	WARN_ON_ONCE(!ip6mr_can_free_table(net));



	timer_shutdown_sync(&mrt->ipmr_expire_timer);

	mroute_clean_tables(mrt, MRT6_FLUSH_MIFS | MRT6_FLUSH_MIFS_STATIC |