Commit f78fb257 authored by Yao Zi's avatar Yao Zi Committed by Huacai Chen
Browse files

platform/loongarch: laptop: Unregister generic_sub_drivers on exit 



Without correct unregisteration, ACPI notify handlers and the platform
drivers installed by generic_subdriver_init() will become dangling
references after removing the loongson_laptop module, triggering various
kernel faults when a hotkey is sent or at kernel shutdown.

Cc: stable@vger.kernel.org
Fixes: 6246ed09 ("LoongArch: Add ACPI-based generic laptop driver")
Signed-off-by: default avatarYao Zi <ziyao@disroot.org>
Signed-off-by: default avatarHuacai Chen <chenhuacai@loongson.cn>
parent 53c762b4

drivers/platform/loongarch/loongson-laptop.c

+9 −3
Original line number Diff line number Diff line
@@ -612,11 +612,17 @@ static int __init generic_acpi_laptop_init(void) 


static void __exit generic_acpi_laptop_exit(void)

{

	int i;



	if (generic_inputdev) {

		if (input_device_registered)

			input_unregister_device(generic_inputdev);

		else

		if (!input_device_registered) {

			input_free_device(generic_inputdev);

		} else {

			input_unregister_device(generic_inputdev);



			for (i = 0; i < ARRAY_SIZE(generic_sub_drivers); i++)

				generic_subdriver_exit(&generic_sub_drivers[i]);

		}

	}

}