Commit f7a680e9 authored by Bartosz Golaszewski's avatar Bartosz Golaszewski
Browse files

gpio: wm8350: use new GPIO line value setter callbacks 



struct gpio_chip now has callbacks for setting line values that return
an integer, allowing to indicate failures. Convert the driver to using
them.

Reviewed-by: default avatarCharles Keepax <ckeepax@opensource.cirrus.com>
Link: https://lore.kernel.org/r/20250709-gpiochip-set-rv-gpio-remaining-v1-7-b8950f69618d@linaro.org


Signed-off-by: default avatarBartosz Golaszewski <bartosz.golaszewski@linaro.org>
parent 023a24f8

drivers/gpio/gpio-wm8350.c

+7 −8
Original line number Diff line number Diff line
@@ -48,15 +48,16 @@ static int wm8350_gpio_get(struct gpio_chip *chip, unsigned offset) 
		return 0;

}



static void wm8350_gpio_set(struct gpio_chip *chip, unsigned offset, int value)

static int wm8350_gpio_set(struct gpio_chip *chip, unsigned int offset,

			   int value)

{

	struct wm8350_gpio_data *wm8350_gpio = gpiochip_get_data(chip);

	struct wm8350 *wm8350 = wm8350_gpio->wm8350;



	if (value)

		wm8350_set_bits(wm8350, WM8350_GPIO_LEVEL, 1 << offset);

	else

		wm8350_clear_bits(wm8350, WM8350_GPIO_LEVEL, 1 << offset);

		return wm8350_set_bits(wm8350, WM8350_GPIO_LEVEL, 1 << offset);



	return wm8350_clear_bits(wm8350, WM8350_GPIO_LEVEL, 1 << offset);

}



static int wm8350_gpio_direction_out(struct gpio_chip *chip,
@@ -72,9 +73,7 @@ static int wm8350_gpio_direction_out(struct gpio_chip *chip, 
		return ret;



	/* Don't have an atomic direction/value setup */

	wm8350_gpio_set(chip, offset, value);



	return 0;

	return wm8350_gpio_set(chip, offset, value);

}



static int wm8350_gpio_to_irq(struct gpio_chip *chip, unsigned offset)
@@ -94,7 +93,7 @@ static const struct gpio_chip template_chip = { 
	.direction_input	= wm8350_gpio_direction_in,

	.get			= wm8350_gpio_get,

	.direction_output	= wm8350_gpio_direction_out,

	.set			= wm8350_gpio_set,

	.set_rv			= wm8350_gpio_set,

	.to_irq			= wm8350_gpio_to_irq,

	.can_sleep		= true,

};