Commit f800cc58 authored by Thomas Weißschuh's avatar Thomas Weißschuh Committed by Greg Kroah-Hartman
Browse files

accel/habanalabs: constify 'struct bin_attribute' 



The sysfs core now allows instances of 'struct bin_attribute' to be
moved into read-only memory. Make use of that to protect them against
accidental or malicious modifications.

Signed-off-by: default avatarThomas Weißschuh <linux@weissschuh.net>
Reviewed-by: default avatarJani Nikula <jani.nikula@intel.com>
Link: https://lore.kernel.org/r/20241216-sysfs-const-bin_attr-habanalabs-v1-1-b35463197efb@weissschuh.net


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 4ab02798

drivers/accel/habanalabs/common/sysfs.c

+5 −5
Original line number Diff line number Diff line
@@ -368,7 +368,7 @@ static ssize_t max_power_store(struct device *dev, 
}



static ssize_t eeprom_read_handler(struct file *filp, struct kobject *kobj,

			struct bin_attribute *attr, char *buf, loff_t offset,

			const struct bin_attribute *attr, char *buf, loff_t offset,

			size_t max_size)

{

	struct device *dev = kobj_to_dev(kobj);
@@ -443,10 +443,10 @@ static DEVICE_ATTR_RO(security_enabled); 
static DEVICE_ATTR_RO(module_id);

static DEVICE_ATTR_RO(parent_device);



static struct bin_attribute bin_attr_eeprom = {

static const struct bin_attribute bin_attr_eeprom = {

	.attr = {.name = "eeprom", .mode = (0444)},

	.size = PAGE_SIZE,

	.read = eeprom_read_handler

	.read_new = eeprom_read_handler

};



static struct attribute *hl_dev_attrs[] = {
@@ -472,14 +472,14 @@ static struct attribute *hl_dev_attrs[] = { 
	NULL,

};



static struct bin_attribute *hl_dev_bin_attrs[] = {

static const struct bin_attribute *const hl_dev_bin_attrs[] = {

	&bin_attr_eeprom,

	NULL

};



static struct attribute_group hl_dev_attr_group = {

	.attrs = hl_dev_attrs,

	.bin_attrs = hl_dev_bin_attrs,

	.bin_attrs_new = hl_dev_bin_attrs,

};



static struct attribute_group hl_dev_clks_attr_group;