Unverified Commit f8138f2a authored by Jann Horn's avatar Jann Horn Committed by Christian Brauner
Browse files

filelock: Fix fcntl/close race recovery compat path 

When I wrote commit 3cad1bc0 ("filelock: Remove locks reliably when
fcntl/close race is detected"), I missed that there are two copies of the
code I was patching: The normal version, and the version for 64-bit offsets
on 32-bit kernels.
Thanks to Greg KH for stumbling over this while doing the stable
backport...

Apply exactly the same fix to the compat path for 32-bit kernels.

Fixes: c293621b ("[PATCH] stale POSIX lock handling")
Cc: stable@kernel.org
Link: https://bugs.chromium.org/p/project-zero/issues/detail?id=2563


Signed-off-by: default avatarJann Horn <jannh@google.com>
Link: https://lore.kernel.org/r/20240723-fs-lock-recover-compatfix-v1-1-148096719529@google.com


Signed-off-by: default avatarChristian Brauner <brauner@kernel.org>
parent 8eac5358

fs/locks.c

+4 −5
Original line number Diff line number Diff line
@@ -2570,8 +2570,9 @@ int fcntl_setlk64(unsigned int fd, struct file *filp, unsigned int cmd, 
	error = do_lock_file_wait(filp, cmd, file_lock);



	/*

	 * Attempt to detect a close/fcntl race and recover by releasing the

	 * lock that was just acquired. There is no need to do that when we're

	 * Detect close/fcntl races and recover by zapping all POSIX locks

	 * associated with this file and our files_struct, just like on

	 * filp_flush(). There is no need to do that when we're

	 * unlocking though, or for OFD locks.

	 */

	if (!error && file_lock->c.flc_type != F_UNLCK &&
@@ -2586,9 +2587,7 @@ int fcntl_setlk64(unsigned int fd, struct file *filp, unsigned int cmd, 
		f = files_lookup_fd_locked(files, fd);

		spin_unlock(&files->file_lock);

		if (f != filp) {

			file_lock->c.flc_type = F_UNLCK;

			error = do_lock_file_wait(filp, cmd, file_lock);

			WARN_ON_ONCE(error);

			locks_remove_posix(filp, files);

			error = -EBADF;

		}

	}