Commit f8209eef authored by Kalle Valo's avatar Kalle Valo
Browse files

wifi: ath12k: hal: convert offset macros to functions 



After previous patch checkpatch was giving warnings:

drivers/net/wireless/ath/ath12k/hal.h:158: Macro argument reuse 'ab' - possible side-effects?
drivers/net/wireless/ath/ath12k/hal.h:160: Macro argument reuse 'ab' - possible side-effects?
drivers/net/wireless/ath/ath12k/hal.h:162: Macro argument reuse 'ab' - possible side-effects?
drivers/net/wireless/ath/ath12k/hal.h:164: Macro argument reuse 'ab' - possible side-effects?
drivers/net/wireless/ath/ath12k/hal.h:173: Macro argument reuse 'ab' - possible side-effects?
drivers/net/wireless/ath/ath12k/hal.h:175: Macro argument reuse 'ab' - possible side-effects?
drivers/net/wireless/ath/ath12k/hal.h:177: Macro argument reuse 'ab' - possible side-effects?
drivers/net/wireless/ath/ath12k/hal.h:179: Macro argument reuse 'ab' - possible side-effects?

To fix those convert the macros into functions. As it was difficult to use
struct ath12k_base within hal.h, core.h was already including hal.h so
including back core.h would not work, move the functions also to hal.c.

No functional changes.

Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0-03427-QCAHMTSWPL_V1.0_V2.0_SILICONZ-1.15378.4

Signed-off-by: default avatarKalle Valo <quic_kvalo@quicinc.com>
Link: https://lore.kernel.org/r/20221220120655.19389-3-kvalo@kernel.org
parent 1a8dc2eb

drivers/net/wireless/ath/ath12k/hal.c

+54 −9
Original line number Diff line number Diff line
@@ -242,6 +242,51 @@ ath12k_hal_wcn7850_tcl_to_wbm_rbm_map[DP_TCL_NUM_RING_MAX] = { 
	},

};



static unsigned int ath12k_hal_reo1_ring_id_offset(struct ath12k_base *ab)

{

	return HAL_REO1_RING_ID(ab) - HAL_REO1_RING_BASE_LSB(ab);

}



static unsigned int ath12k_hal_reo1_ring_msi1_base_lsb_offset(struct ath12k_base *ab)

{

	return HAL_REO1_RING_MSI1_BASE_LSB(ab) - HAL_REO1_RING_BASE_LSB(ab);

}



static unsigned int ath12k_hal_reo1_ring_msi1_base_msb_offset(struct ath12k_base *ab)

{

	return HAL_REO1_RING_MSI1_BASE_MSB(ab) - HAL_REO1_RING_BASE_LSB(ab);

}



static unsigned int ath12k_hal_reo1_ring_msi1_data_offset(struct ath12k_base *ab)

{

	return HAL_REO1_RING_MSI1_DATA(ab) - HAL_REO1_RING_BASE_LSB(ab);

}



static unsigned int ath12k_hal_reo1_ring_base_msb_offset(struct ath12k_base *ab)

{

	return HAL_REO1_RING_BASE_MSB(ab) - HAL_REO1_RING_BASE_LSB(ab);

}



static unsigned int ath12k_hal_reo1_ring_producer_int_setup_offset(struct ath12k_base *ab)

{

	return HAL_REO1_RING_PRODUCER_INT_SETUP(ab) - HAL_REO1_RING_BASE_LSB(ab);

}



static unsigned int ath12k_hal_reo1_ring_hp_addr_lsb_offset(struct ath12k_base *ab)

{

	return HAL_REO1_RING_HP_ADDR_LSB(ab) - HAL_REO1_RING_BASE_LSB(ab);

}



static unsigned int ath12k_hal_reo1_ring_hp_addr_msb_offset(struct ath12k_base *ab)

{

	return HAL_REO1_RING_HP_ADDR_MSB(ab) - HAL_REO1_RING_BASE_LSB(ab);

}



static unsigned int ath12k_hal_reo1_ring_misc_offset(struct ath12k_base *ab)

{

	return HAL_REO1_RING_MISC(ab) - HAL_REO1_RING_BASE_LSB(ab);

}



static bool ath12k_hw_qcn9274_rx_desc_get_first_msdu(struct hal_rx_desc *desc)

{

	return !!le16_get_bits(desc->u.qcn9274.msdu_end.info5,
@@ -1217,17 +1262,17 @@ static void ath12k_hal_srng_dst_hw_init(struct ath12k_base *ab, 


	if (srng->flags & HAL_SRNG_FLAGS_MSI_INTR) {

		ath12k_hif_write32(ab, reg_base +

				   HAL_REO1_RING_MSI1_BASE_LSB_OFFSET(ab),

				   ath12k_hal_reo1_ring_msi1_base_lsb_offset(ab),

				   srng->msi_addr);



		val = u32_encode_bits(((u64)srng->msi_addr >> HAL_ADDR_MSB_REG_SHIFT),

				      HAL_REO1_RING_MSI1_BASE_MSB_ADDR) |

				      HAL_REO1_RING_MSI1_BASE_MSB_MSI1_ENABLE;

		ath12k_hif_write32(ab, reg_base +

				   HAL_REO1_RING_MSI1_BASE_MSB_OFFSET(ab), val);

				   ath12k_hal_reo1_ring_msi1_base_msb_offset(ab), val);



		ath12k_hif_write32(ab,

				   reg_base + HAL_REO1_RING_MSI1_DATA_OFFSET(ab),

				   reg_base + ath12k_hal_reo1_ring_msi1_data_offset(ab),

				   srng->msi_data);

	}
@@ -1237,11 +1282,11 @@ static void ath12k_hal_srng_dst_hw_init(struct ath12k_base *ab, 
			      HAL_REO1_RING_BASE_MSB_RING_BASE_ADDR_MSB) |

	      u32_encode_bits((srng->entry_size * srng->num_entries),

			      HAL_REO1_RING_BASE_MSB_RING_SIZE);

	ath12k_hif_write32(ab, reg_base + HAL_REO1_RING_BASE_MSB_OFFSET(ab), val);

	ath12k_hif_write32(ab, reg_base + ath12k_hal_reo1_ring_base_msb_offset(ab), val);



	val = u32_encode_bits(srng->ring_id, HAL_REO1_RING_ID_RING_ID) |

	      u32_encode_bits(srng->entry_size, HAL_REO1_RING_ID_ENTRY_SIZE);

	ath12k_hif_write32(ab, reg_base + HAL_REO1_RING_ID_OFFSET(ab), val);

	ath12k_hif_write32(ab, reg_base + ath12k_hal_reo1_ring_id_offset(ab), val);



	/* interrupt setup */

	val = u32_encode_bits((srng->intr_timer_thres_us >> 3),
@@ -1251,15 +1296,15 @@ static void ath12k_hal_srng_dst_hw_init(struct ath12k_base *ab, 
				HAL_REO1_RING_PRDR_INT_SETUP_BATCH_COUNTER_THOLD);



	ath12k_hif_write32(ab,

			   reg_base + HAL_REO1_RING_PRODUCER_INT_SETUP_OFFSET(ab),

			   reg_base + ath12k_hal_reo1_ring_producer_int_setup_offset(ab),

			   val);



	hp_addr = hal->rdp.paddr +

		  ((unsigned long)srng->u.dst_ring.hp_addr -

		   (unsigned long)hal->rdp.vaddr);

	ath12k_hif_write32(ab, reg_base + HAL_REO1_RING_HP_ADDR_LSB_OFFSET(ab),

	ath12k_hif_write32(ab, reg_base + ath12k_hal_reo1_ring_hp_addr_lsb_offset(ab),

			   hp_addr & HAL_ADDR_LSB_REG_MASK);

	ath12k_hif_write32(ab, reg_base + HAL_REO1_RING_HP_ADDR_MSB_OFFSET(ab),

	ath12k_hif_write32(ab, reg_base + ath12k_hal_reo1_ring_hp_addr_msb_offset(ab),

			   hp_addr >> HAL_ADDR_MSB_REG_SHIFT);



	/* Initialize head and tail pointers to indicate ring is empty */
@@ -1278,7 +1323,7 @@ static void ath12k_hal_srng_dst_hw_init(struct ath12k_base *ab, 
		val |= HAL_REO1_RING_MISC_MSI_SWAP;

	val |= HAL_REO1_RING_MISC_SRNG_ENABLE;



	ath12k_hif_write32(ab, reg_base + HAL_REO1_RING_MISC_OFFSET(ab), val);

	ath12k_hif_write32(ab, reg_base + ath12k_hal_reo1_ring_misc_offset(ab), val);

}



static void ath12k_hal_srng_src_hw_init(struct ath12k_base *ab,

drivers/net/wireless/ath/ath12k/hal.h

+0 −24
Original line number Diff line number Diff line
@@ -155,30 +155,6 @@ struct ath12k_base; 
#define HAL_REO1_AGING_THRESH_IX_2(ab)	((ab)->hw_params->regs->hal_reo1_aging_thres_ix2)

#define HAL_REO1_AGING_THRESH_IX_3(ab)	((ab)->hw_params->regs->hal_reo1_aging_thres_ix3)



#define HAL_REO1_RING_MSI1_BASE_LSB_OFFSET(ab)				\

		(HAL_REO1_RING_MSI1_BASE_LSB(ab) - HAL_REO1_RING_BASE_LSB(ab))

#define HAL_REO1_RING_MSI1_BASE_MSB_OFFSET(ab)				\

		(HAL_REO1_RING_MSI1_BASE_MSB(ab) - HAL_REO1_RING_BASE_LSB(ab))

#define HAL_REO1_RING_MSI1_DATA_OFFSET(ab)				\

		(HAL_REO1_RING_MSI1_DATA(ab) - HAL_REO1_RING_BASE_LSB(ab))

#define HAL_REO1_RING_BASE_MSB_OFFSET(ab)				\

		(HAL_REO1_RING_BASE_MSB(ab) - HAL_REO1_RING_BASE_LSB(ab))



#define HAL_REO1_RING_ID_OFFSET(ab)					\

	({								\

		struct ath12k_base *_ab = (ab);				\

		(HAL_REO1_RING_ID(_ab) - HAL_REO1_RING_BASE_LSB(_ab));	\

	})



#define HAL_REO1_RING_PRODUCER_INT_SETUP_OFFSET(ab)			\

		(HAL_REO1_RING_PRODUCER_INT_SETUP(ab) - HAL_REO1_RING_BASE_LSB(ab))

#define HAL_REO1_RING_HP_ADDR_LSB_OFFSET(ab)				\

		(HAL_REO1_RING_HP_ADDR_LSB(ab) - HAL_REO1_RING_BASE_LSB(ab))

#define HAL_REO1_RING_HP_ADDR_MSB_OFFSET(ab)				\

		(HAL_REO1_RING_HP_ADDR_MSB(ab) - HAL_REO1_RING_BASE_LSB(ab))

#define HAL_REO1_RING_MISC_OFFSET(ab)					\

		(HAL_REO1_RING_MISC(ab) - HAL_REO1_RING_BASE_LSB(ab))



/* REO2SW(x) R2 ring pointers (head/tail) address */

#define HAL_REO1_RING_HP			0x00003048

#define HAL_REO1_RING_TP			0x0000304c