Commit f8dc4394 authored by Colin Ian King's avatar Colin Ian King Committed by Rafael J. Wysocki
Browse files

ACPI: pfr_telemetry: remove redundant error check on ret 



The variable ret is initialized to zero and a littler later in
the PFRT_LOG_IOC_GET_INFO case of a switch statement is being checked
for negative error value. Since ret has not been re-assigned since
the initialization ret can never be less than zero so the check is
redundant and can be removed. Remove it.

Signed-off-by: default avatarColin Ian King <colin.i.king@gmail.com>
Link: https://patch.msgid.link/20241014130522.1986428-1-colin.i.king@gmail.com


Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent 42f7652d

drivers/acpi/pfr_telemetry.c

+0 −3
Original line number Diff line number Diff line
@@ -272,9 +272,6 @@ static long pfrt_log_ioctl(struct file *file, unsigned int cmd, unsigned long ar 


	case PFRT_LOG_IOC_GET_INFO:

		info.log_level = get_pfrt_log_level(pfrt_log_dev);

		if (ret < 0)

			return ret;



		info.log_type = pfrt_log_dev->info.log_type;

		info.log_revid = pfrt_log_dev->info.log_revid;

		if (copy_to_user(p, &info, sizeof(info)))