Commit f8f530ba authored by Dan Carpenter's avatar Dan Carpenter Committed by Vinod Koul
Browse files

dmaengine: qcom: gpi: clean up the IRQ disable/enable in gpi_reset_chan() 



The calls write_lock/unlock_irq() disables and re-enables the IRQs.
Calling spin_lock_irqsave() and spin_lock_restore() when the IRQs are
already disabled doesn't do anything and just makes the code confusing.

Signed-off-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/8be473eb-65e0-42b4-b574-e61c3a7f62d8@moroto.mountain


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent 8ddad558

drivers/dma/qcom/gpi.c

+2 −3
Original line number Diff line number Diff line
@@ -1191,7 +1191,6 @@ static int gpi_reset_chan(struct gchan *gchan, enum gpi_cmd gpi_cmd) 
{

	struct gpii *gpii = gchan->gpii;

	struct gpi_ring *ch_ring = &gchan->ch_ring;

	unsigned long flags;

	LIST_HEAD(list);

	int ret;
@@ -1214,9 +1213,9 @@ static int gpi_reset_chan(struct gchan *gchan, enum gpi_cmd gpi_cmd) 
	gpi_mark_stale_events(gchan);



	/* remove all async descriptors */

	spin_lock_irqsave(&gchan->vc.lock, flags);

	spin_lock(&gchan->vc.lock);

	vchan_get_all_descriptors(&gchan->vc, &list);

	spin_unlock_irqrestore(&gchan->vc.lock, flags);

	spin_unlock(&gchan->vc.lock);

	write_unlock_irq(&gpii->pm_lock);

	vchan_dma_desc_free_list(&gchan->vc, &list);