Commit f8fd0968 authored by Yang Yingliang's avatar Yang Yingliang Committed by Neil Armstrong
Browse files

drm/panel: novatek-nt35950: fix return value check in nt35950_probe() 



mipi_dsi_device_register_full() never returns NULL pointer, it
will return ERR_PTR() when it fails, so replace the check with
IS_ERR().

Fixes: 623a3531 ("drm/panel: Add driver for Novatek NT35950 DSI DriverIC panels")
Signed-off-by: default avatarYang Yingliang <yangyingliang@huawei.com>
Reviewed-by: default avatarNeil Armstrong <neil.armstrong@linaro.org>
Link: https://lore.kernel.org/r/20241029123957.1588-1-yangyingliang@huaweicloud.com


Signed-off-by: default avatarNeil Armstrong <neil.armstrong@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20241029123957.1588-1-yangyingliang@huaweicloud.com
parent e1e1af91

drivers/gpu/drm/panel/panel-novatek-nt35950.c

+2 −2
Original line number Diff line number Diff line
@@ -481,9 +481,9 @@ static int nt35950_probe(struct mipi_dsi_device *dsi) 
			return dev_err_probe(dev, -EPROBE_DEFER, "Cannot get secondary DSI host\n");



		nt->dsi[1] = mipi_dsi_device_register_full(dsi_r_host, info);

		if (!nt->dsi[1]) {

		if (IS_ERR(nt->dsi[1])) {

			dev_err(dev, "Cannot get secondary DSI node\n");

			return -ENODEV;

			return PTR_ERR(nt->dsi[1]);

		}

		num_dsis++;

	}