Commit f90b474a authored by Vlastimil Babka's avatar Vlastimil Babka Committed by Alexei Starovoitov
Browse files

mm: Fix the flipped condition in gfpflags_allow_spinning() 



The function gfpflags_allow_spinning() has a bug that makes it return
the opposite result than intended. This could contribute to deadlocks as
usage profilerates, for now it was noticed as a performance regression
due to try_charge_memcg() not refilling memcg stock when it could. Fix
the flipped condition.

Fixes: 97769a53 ("mm, bpf: Introduce try_alloc_pages() for opportunistic page allocation")
Reported-by: default avatarkernel test robot <oliver.sang@intel.com>
Acked-by: default avatarShakeel Butt <shakeel.butt@linux.dev>
Signed-off-by: default avatarVlastimil Babka <vbabka@suse.cz>
Signed-off-by: default avatarAndrii Nakryiko <andrii@kernel.org>
Link: https://lore.kernel.org/bpf/20250310124017.187-1-alexei.starovoitov@gmail.com
Closes: https://lore.kernel.org/oe-lkp/202503101254.cfd454df-lkp@intel.com


Signed-off-by: default avatarAlexei Starovoitov <ast@kernel.org>
parent 93ed6fc2

include/linux/gfp.h

+1 −1
Original line number Diff line number Diff line
@@ -55,7 +55,7 @@ static inline bool gfpflags_allow_spinning(const gfp_t gfp_flags) 
	 * regular page allocator doesn't fully support this

	 * allocation mode.

	 */

	return !(gfp_flags & __GFP_RECLAIM);

	return !!(gfp_flags & __GFP_RECLAIM);

}



#ifdef CONFIG_HIGHMEM