Commit f9837147 authored by Linus Walleij's avatar Linus Walleij
Browse files

pinctrl: qcom: ssbi-gpio: Fix fwspec parsing bug 



We are parsing SSBI gpios as fourcell fwspecs but they are
twocell. Probably a simple copy-and-paste bug.

Tested on the APQ8060 DragonBoard and after this ethernet
and MMC card detection works again.

Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: stable@vger.kernel.org
Reviewed-by: default avatarBrian Masney <masneyb@onstation.org>
Fixes: ae436fe8 ("pinctrl: ssbi-gpio: convert to hierarchical IRQ helpers in gpio core")
Link: https://lore.kernel.org/r/20200306143416.1476250-1-linus.walleij@linaro.org


Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 3567ee83

drivers/pinctrl/qcom/pinctrl-ssbi-gpio.c

+1 −1
Original line number Diff line number Diff line
@@ -794,7 +794,7 @@ static int pm8xxx_gpio_probe(struct platform_device *pdev) 
	girq->fwnode = of_node_to_fwnode(pctrl->dev->of_node);

	girq->parent_domain = parent_domain;

	girq->child_to_parent_hwirq = pm8xxx_child_to_parent_hwirq;

	girq->populate_parent_alloc_arg = gpiochip_populate_parent_fwspec_fourcell;

	girq->populate_parent_alloc_arg = gpiochip_populate_parent_fwspec_twocell;

	girq->child_offset_to_irq = pm8xxx_child_offset_to_irq;

	girq->child_irq_domain_ops.translate = pm8xxx_domain_translate;