Commit f9d1b528 authored by Dan Carpenter's avatar Dan Carpenter Committed by Dmitry Baryshkov
Browse files

drm/msm/dpu: fix error pointer dereference in msm_kms_init_aspace() 



If msm_gem_address_space_create() fails, then return right away.
Otherwise it leads to a Oops when we dereference "aspace" on the next
line.

Fixes: eabba31a ("drm/msm: register a fault handler for display mmu faults")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: default avatarDmitry Baryshkov <dmitry.baryshkov@linaro.org>
Reviewed-by: default avatarAbhinav Kumar <quic_abhinavk@quicinc.com>
Patchwork: https://patchwork.freedesktop.org/patch/639357/
Link: https://lore.kernel.org/r/3221e88c-3351-42e6-aeb1-69f4f014b509@stanley.mountain


[DB: fixed commit id]
Signed-off-by: default avatarDmitry Baryshkov <dmitry.baryshkov@linaro.org>
parent ea54cfac

drivers/gpu/drm/msm/msm_kms.c

+1 −0
Original line number Diff line number Diff line
@@ -209,6 +209,7 @@ struct msm_gem_address_space *msm_kms_init_aspace(struct drm_device *dev) 
	if (IS_ERR(aspace)) {

		dev_err(mdp_dev, "aspace create, error %pe\n", aspace);

		mmu->funcs->destroy(mmu);

		return aspace;

	}



	msm_mmu_set_fault_handler(aspace->mmu, kms, msm_kms_fault_handler);