Commit f9d9f94c authored by Rodrigo Vivi's avatar Rodrigo Vivi
Browse files

drm/xe: Remove useless mem_access protection for query ioctls 



Every IOCTL is already protected on its outer bounds by
xe_pm_runtime_{get,put} calls, so we can now remove
these.

Reviewed-by: default avatarMatthew Auld <matthew.auld@intel.com>
Signed-off-by: default avatarRodrigo Vivi <rodrigo.vivi@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240222163937.138342-10-rodrigo.vivi@intel.com
parent 5a2a9084

drivers/gpu/drm/xe/xe_query.c

+0 −4
Original line number Diff line number Diff line
@@ -147,7 +147,6 @@ query_engine_cycles(struct xe_device *xe, 
	if (!hwe)

		return -EINVAL;



	xe_device_mem_access_get(xe);

	xe_force_wake_get(gt_to_fw(gt), XE_FORCEWAKE_ALL);



	__read_timestamps(gt,
@@ -159,7 +158,6 @@ query_engine_cycles(struct xe_device *xe, 
			  cpu_clock);



	xe_force_wake_put(gt_to_fw(gt), XE_FORCEWAKE_ALL);

	xe_device_mem_access_put(xe);

	resp.width = 36;



	/* Only write to the output fields of user query */
@@ -433,9 +431,7 @@ static int query_hwconfig(struct xe_device *xe, 
	if (!hwconfig)

		return -ENOMEM;



	xe_device_mem_access_get(xe);

	xe_guc_hwconfig_copy(&gt->uc.guc, hwconfig);

	xe_device_mem_access_put(xe);



	if (copy_to_user(query_ptr, hwconfig, size)) {

		kfree(hwconfig);