Commit fa5c4ba8 authored Dec 20, 2024 by Chengchang Tang Committed by Leon Romanovsky Dec 23, 2024

RDMA/hns: Fix warning storm caused by invalid input in IO path

WARN_ON() is called in the IO path. And it could lead to a warning
storm. Use WARN_ON_ONCE() instead of WARN_ON().

Fixes: 12542f1d ("RDMA/hns: Refactor process about opcode in post_send()")
Signed-off-by: Chengchang Tang <tangchengchang@huawei.com>
Signed-off-by: Junxian Huang <huangjunxian6@hisilicon.com>
Link: https://patch.msgid.link/20241220055249.146943-4-huangjunxian6@hisilicon.com

Signed-off-by: Leon Romanovsky <leon@kernel.org>

parent 0572eccf

drivers/infiniband/hw/hns/hns_roce_hw_v2.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -468,7 +468,7 @@ static inline int set_ud_wqe(struct hns_roce_qp *qp,
		valid_num_sge = calc_wr_sge_num(wr, &msg_len);

		ret = set_ud_opcode(ud_sq_wqe, wr);
		if (WARN_ON(ret))
		if (WARN_ON_ONCE(ret))
		return ret;

		ud_sq_wqe->msg_len = cpu_to_le32(msg_len);
		@@ -572,7 +572,7 @@ static inline int set_rc_wqe(struct hns_roce_qp *qp,
		rc_sq_wqe->msg_len = cpu_to_le32(msg_len);

		ret = set_rc_opcode(hr_dev, rc_sq_wqe, wr);
		if (WARN_ON(ret))
		if (WARN_ON_ONCE(ret))
		return ret;

		hr_reg_write(rc_sq_wqe, RC_SEND_WQE_SO,