Commit fa855563 authored by Bart Van Assche's avatar Bart Van Assche Committed by Jens Axboe
Browse files

blk-zoned: Improve the queue reference count strategy documentation 



For the blk_queue_exit() calls, document where the corresponding code can
be found that increases q->q_usage_counter.

Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Reviewed-by: default avatarDamien Le Moal <dlemoal@kernel.org>
Signed-off-by: default avatarBart Van Assche <bvanassche@acm.org>
Link: https://lore.kernel.org/r/20241217210310.645966-4-bvanassche@acm.org


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent cbac56e5

block/blk-zoned.c

+2 −4
Original line number Diff line number Diff line
@@ -582,6 +582,7 @@ static inline void blk_zone_wplug_bio_io_error(struct blk_zone_wplug *zwplug, 
	bio_clear_flag(bio, BIO_ZONE_WRITE_PLUGGING);

	bio_io_error(bio);

	disk_put_zone_wplug(zwplug);

	/* Drop the reference taken by disk_zone_wplug_add_bio(() */

	blk_queue_exit(q);

}
@@ -893,10 +894,7 @@ void blk_zone_write_plug_init_request(struct request *req) 
			break;

		}



		/*

		 * Drop the extra reference on the queue usage we got when

		 * plugging the BIO and advance the write pointer offset.

		 */

		/* Drop the reference taken by disk_zone_wplug_add_bio(). */

		blk_queue_exit(q);

		zwplug->wp_offset += bio_sectors(bio);