Commit fa9586bd authored by Adrian Hunter's avatar Adrian Hunter Committed by Alexandre Belloni
Browse files

i3c: mipi-i3c-hci: Fix Hot-Join NACK 



The MIPI I3C HCI host controller driver does not implement Hot-Join
handling, yet Hot-Join response control defaults to allowing devices to
Hot-Join the bus.  Configure HC_CONTROL_HOT_JOIN_CTRL to NACK all Hot-Join
attempts.

Fixes: 9ad9a52c ("i3c/master: introduce the mipi-i3c-hci driver")
Cc: stable@vger.kernel.org
Signed-off-by: default avatarAdrian Hunter <adrian.hunter@intel.com>
Reviewed-by: default avatarFrank Li <Frank.Li@nxp.com>
Link: https://patch.msgid.link/20260306072451.11131-3-adrian.hunter@intel.com


Signed-off-by: default avatarAlexandre Belloni <alexandre.belloni@bootlin.com>
parent 4167b891

drivers/i3c/master/mipi-i3c-hci/core.c

+4 −2
Original line number Diff line number Diff line
@@ -152,7 +152,8 @@ static int i3c_hci_bus_init(struct i3c_master_controller *m) 
	if (hci->quirks & HCI_QUIRK_RESP_BUF_THLD)

		amd_set_resp_buf_thld(hci);



	reg_set(HC_CONTROL, HC_CONTROL_BUS_ENABLE);

	/* Enable bus with Hot-Join disabled */

	reg_set(HC_CONTROL, HC_CONTROL_BUS_ENABLE | HC_CONTROL_HOT_JOIN_CTRL);

	dev_dbg(&hci->master.dev, "HC_CONTROL = %#x", reg_read(HC_CONTROL));



	return 0;
@@ -764,7 +765,8 @@ static int i3c_hci_runtime_resume(struct device *dev) 


	hci->io->resume(hci);



	reg_set(HC_CONTROL, HC_CONTROL_BUS_ENABLE);

	/* Enable bus with Hot-Join disabled */

	reg_set(HC_CONTROL, HC_CONTROL_BUS_ENABLE | HC_CONTROL_HOT_JOIN_CTRL);



	return 0;

}