Commit fb22b1fc authored by Jon Hunter's avatar Jon Hunter Committed by Jakub Kicinski
Browse files

dt-bindings: net: Fix Tegra234 MGBE PTP clock 



The PTP clock for the Tegra234 MGBE device is incorrectly named
'ptp-ref' and should be 'ptp_ref'. This is causing the following
warning to be observed on Tegra234 platforms that use this device:

 ERR KERN tegra-mgbe 6800000.ethernet eth0: Invalid PTP clock rate
 WARNING KERN tegra-mgbe 6800000.ethernet eth0: PTP init failed

Although this constitutes an ABI breakage in the binding for this
device, PTP support has clearly never worked and so fix this now
so we can correct the device-tree for this device. Note that the
MGBE driver still supports the legacy 'ptp-ref' clock name and so
older/existing device-trees will still work, but given that this
is not the correct name, there is no point to advertise this in the
binding.

Fixes: 189c2e5c ("dt-bindings: net: Add Tegra234 MGBE")
Signed-off-by: default avatarJon Hunter <jonathanh@nvidia.com>
Reviewed-by: default avatarKrzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Link: https://patch.msgid.link/20260401102941.17466-3-jonathanh@nvidia.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 1345e9f4

Documentation/devicetree/bindings/net/nvidia,tegra234-mgbe.yaml

+2 −2
Original line number Diff line number Diff line
@@ -42,7 +42,7 @@ properties: 
      - const: mgbe

      - const: mac

      - const: mac-divider

      - const: ptp-ref

      - const: ptp_ref

      - const: rx-input-m

      - const: rx-input

      - const: tx
@@ -133,7 +133,7 @@ examples: 
                 <&bpmp TEGRA234_CLK_MGBE0_RX_PCS_M>,

                 <&bpmp TEGRA234_CLK_MGBE0_RX_PCS>,

                 <&bpmp TEGRA234_CLK_MGBE0_TX_PCS>;

        clock-names = "mgbe", "mac", "mac-divider", "ptp-ref", "rx-input-m",

        clock-names = "mgbe", "mac", "mac-divider", "ptp_ref", "rx-input-m",

                      "rx-input", "tx", "eee-pcs", "rx-pcs-input", "rx-pcs-m",

                      "rx-pcs", "tx-pcs";

        resets = <&bpmp TEGRA234_RESET_MGBE0_MAC>,