Commit fb980409 authored by Heikki Krogerus's avatar Heikki Krogerus Committed by Greg Kroah-Hartman
Browse files

usb: typec: ucsi: Remove useless error check from ucsi_read_error() 



If the GET_ERROR_STATUS command fails, ucsi_read_error() can
not reach the condition where the CCI error bit is checked,
because ucsi_run_command() has already checked that bit and
returned an error.

Signed-off-by: default avatarHeikki Krogerus <heikki.krogerus@linux.intel.com>
Link: https://lore.kernel.org/r/20240816135859.3499351-7-heikki.krogerus@linux.intel.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 4f322657

drivers/usb/typec/ucsi/ucsi.c

+0 −3
Original line number Diff line number Diff line
@@ -148,9 +148,6 @@ static int ucsi_read_error(struct ucsi *ucsi, u8 connector_num) 
	if (ret < 0)

		return ret;



	if (cci & UCSI_CCI_ERROR)

		return -EIO;



	switch (error) {

	case UCSI_ERROR_INCOMPATIBLE_PARTNER:

		return -EOPNOTSUPP;