Commit fc5f5aef authored by furkanonder's avatar furkanonder Committed by Steven Rostedt (Google)
Browse files

tools/rtla: Improve code readability in timerlat_load.py 

The enhancements made to timerlat_load.py are intended to improve the
script's robustness and readability.

Summary of the changes:
- Unnecessary semicolons at the end of lines have been removed.
- Parentheses surrounding the if statement checking args.prio have been
eliminated.
- String concatenation for constructing timerlat_path has been replaced
with an f-string.
- Spacing in a multiplication expression has been adjusted for improved
clarity.

Cc: "jkacur@redhat.com" <jkacur@redhat.com>
Cc: "lgoncalv@redhat.com" <lgoncalv@redhat.com>
Link: https://lore.kernel.org/j2B-ted7pv3TaldTyqfIHrMmjq2fVyBFgnu3TskiQJsyRzy9loPTVVJoqHnrCWu5T88MDIFc612jUglH6Sxkdg9LN-I1XuITmoL70uECmus=@protonmail.com


Signed-off-by: default avatarFurkan Onder <furkanonder@protonmail.com>
Reviewed-by: default avatarTomas Glozar <tglozar@redhat.com>
Signed-off-by: default avatarSteven Rostedt (Google) <rostedt@goodmis.org>
parent fcbc60d7

tools/tracing/rtla/sample/timerlat_load.py

+5 −5
Original line number Diff line number Diff line
@@ -37,12 +37,12 @@ except: 
    exit(1)



try:

    os.sched_setaffinity(0, affinity_mask);

    os.sched_setaffinity(0, affinity_mask)

except:

    print("Error setting affinity")

    exit(1)



if (args.prio):

if args.prio:

    try:

        param = os.sched_param(int(args.prio))

        os.sched_setscheduler(0, os.SCHED_FIFO, param)
@@ -51,14 +51,14 @@ if (args.prio): 
        exit(1)



try:

    timerlat_path = "/sys/kernel/tracing/osnoise/per_cpu/cpu" + args.cpu + "/timerlat_fd"

    timerlat_path = f"/sys/kernel/tracing/osnoise/per_cpu/cpu{args.cpu}/timerlat_fd"

    timerlat_fd = open(timerlat_path, 'r')

except:

    print("Error opening timerlat fd, did you run timerlat -U?")

    exit(1)



try:

    data_fd = open("/dev/full", 'r');

    data_fd = open("/dev/full", 'r')

except:

    print("Error opening data fd")