Commit fccf202e authored by Breno Leitao's avatar Breno Leitao Committed by Greg Kroah-Hartman
Browse files

misc: bcm-vk: Specify the minimum number of IRQ vecs 



During bcm_vk_probe(), pci_alloc_irq_vectors() is called passing the
number of IRQ vectors as 1, but, later, check how many IRQ vectors it
got, and fails if it is smaller than VK_MSIX_IRQ_MIN_REQ.

The most appropriated way to do it is setting the 'min_vecs' param as
VK_MSIX_IRQ_MIN_REQ, instead of one. pci_alloc_irq_vectors() should
know the requirements when called.

The test was done by just loading this module on a machine with a
Valkyrie offload engine hardware.

Acked-by: default avatarScott Branden <scott.branden@broadcom.com>
Signed-off-by: default avatarBreno Leitao <leitao@debian.org>
Link: https://lore.kernel.org/r/20220812094011.4064729-1-leitao@debian.org


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 9d64d240

drivers/misc/bcm-vk/bcm_vk_dev.c

+1 −1
Original line number Diff line number Diff line
@@ -1339,7 +1339,7 @@ static int bcm_vk_probe(struct pci_dev *pdev, const struct pci_device_id *ent) 
	pci_set_drvdata(pdev, vk);



	irq = pci_alloc_irq_vectors(pdev,

				    1,

				    VK_MSIX_IRQ_MIN_REQ,

				    VK_MSIX_IRQ_MAX,

				    PCI_IRQ_MSI | PCI_IRQ_MSIX);