Commit fcf3fb7b authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Martin K. Petersen
Browse files

scsi: ufs: ufs-pci: Switch to use acpi_evaluate_dsm_typed() 



The acpi_evaluate_dsm_typed() provides a way to check the type of the
object evaluated by _DSM call. Use it instead of open coded variant.

Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20231002135125.2602895-1-andriy.shevchenko@linux.intel.com


Reviewed-by: default avatarAvri Altman <avri.altman@wdc.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent e66413fa

drivers/ufs/host/ufshcd-pci.c

+3 −2
Original line number Diff line number Diff line
@@ -58,11 +58,12 @@ static int __intel_dsm(struct intel_host *intel_host, struct device *dev, 
	int err = 0;

	size_t len;



	obj = acpi_evaluate_dsm(ACPI_HANDLE(dev), &intel_dsm_guid, 0, fn, NULL);

	obj = acpi_evaluate_dsm_typed(ACPI_HANDLE(dev), &intel_dsm_guid, 0, fn, NULL,

				      ACPI_TYPE_BUFFER);

	if (!obj)

		return -EOPNOTSUPP;



	if (obj->type != ACPI_TYPE_BUFFER || obj->buffer.length < 1) {

	if (obj->buffer.length < 1) {

		err = -EINVAL;

		goto out;

	}