Commit fdd1faee authored by Pierre-Louis Bossart's avatar Pierre-Louis Bossart Committed by Vinod Koul
Browse files

soundwire: generic_bandwidth_allocation: skip DEPREPARED streams 



We should not blindly walk through all the m_rt list, since it will
have the side effect of accounting for deprepared streams.

This behavior is the result of the split implementation where the
dailink hw_free() handles the stream state change and the bit
allocation, and the dai hw_free() modifies the m_rt list. The bit
allocation ends-up using m_rt entries in zombie state, no longer
relevant but still used.

Signed-off-by: default avatarPierre-Louis Bossart <pierre-louis.bossart@linux.dev>
Signed-off-by: default avatarBard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: default avatarRanjani Sridharan <ranjani.sridharan@linux.intel.com>
Link: https://lore.kernel.org/r/20241218080155.102405-6-yung-chuan.liao@linux.intel.com


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent f1b3dba6

drivers/soundwire/generic_bandwidth_allocation.c

+3 −0
Original line number Diff line number Diff line
@@ -238,6 +238,9 @@ static int sdw_get_group_count(struct sdw_bus *bus, 
		return -ENOMEM;



	list_for_each_entry(m_rt, &bus->m_rt_list, bus_node) {

		if (m_rt->stream->state == SDW_STREAM_DEPREPARED)

			continue;



		rate = m_rt->stream->params.rate;

		if (m_rt == list_first_entry(&bus->m_rt_list,

					     struct sdw_master_runtime,