Commit fe3da77f authored by Bartosz Golaszewski's avatar Bartosz Golaszewski Committed by Philipp Zabel
Browse files

reset: gpio: remove unneeded OF-node put 



priv->rc.of_node is never set in reset core. Even if it were: tasking
the reset-gpio driver with controlling the reference count of an OF node
set up in reset core is a weird inversion of responsability. But it's
also wrong in that the underlying device never actually gets removed so
the node should not be put at all and especially not at driver detach.
Remove the devres action.

Reviewed-by: default avatarPhilipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: default avatarBartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
Signed-off-by: default avatarPhilipp Zabel <p.zabel@pengutronix.de>
parent 9d93e13b

drivers/reset/reset-gpio.c

+0 −10
Original line number Diff line number Diff line
@@ -52,18 +52,12 @@ static int reset_gpio_of_xlate(struct reset_controller_dev *rcdev, 
	return reset_spec->args[0];

}



static void reset_gpio_of_node_put(void *data)

{

	of_node_put(data);

}



static int reset_gpio_probe(struct auxiliary_device *adev,

			    const struct auxiliary_device_id *id)

{

	struct device *dev = &adev->dev;

	struct of_phandle_args *platdata = dev_get_platdata(dev);

	struct reset_gpio_priv *priv;

	int ret;



	if (!platdata)

		return -EINVAL;
@@ -83,10 +77,6 @@ static int reset_gpio_probe(struct auxiliary_device *adev, 
	priv->rc.owner = THIS_MODULE;

	priv->rc.dev = dev;

	priv->rc.of_args = platdata;

	ret = devm_add_action_or_reset(dev, reset_gpio_of_node_put,

				       priv->rc.of_node);

	if (ret)

		return ret;



	/* Cells to match GPIO specifier, but it's not really used */

	priv->rc.of_reset_n_cells = 2;