Commit fece8598 authored by Himal Prasad Ghimiray's avatar Himal Prasad Ghimiray
Browse files

drm/xe/vm: Fix error handling in xe_vm_query_vmas_attrs_ioctl() 



copy_to_user() returns the number of bytes not copied on failure, not a
negative error code. Update the logic to return -EFAULT instead of the
number of bytes to correctly signal the error.

Fixes: 41880786 ("drm/xe/uapi: Add UAPI for querying VMA count and memory attributes")
Cc: Matthew Brost <matthew.brost@intel.com>
Cc: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: default avatarTejas Upadhyay <tejas.upadhyay@intel.com>
Link: https://lore.kernel.org/r/20250828104933.3839825-3-himal.prasad.ghimiray@intel.com


Signed-off-by: default avatarHimal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>
parent 294912f9

drivers/gpu/drm/xe/xe_vm.c

+2 −0
Original line number Diff line number Diff line
@@ -2288,6 +2288,8 @@ int xe_vm_query_vmas_attrs_ioctl(struct drm_device *dev, void *data, struct drm_ 


	err = copy_to_user(attrs_user, mem_attrs,

			   args->sizeof_mem_range_attr * args->num_mem_ranges);

	if (err)

		err = -EFAULT;



free_mem_attrs:

	kvfree(mem_attrs);