Commit ff0f0d7c authored by Bartosz Golaszewski's avatar Bartosz Golaszewski
Browse files

gpio: wcd934x: check the return value of regmap_update_bits() 

regmap_update_bits() can fail so check its return value in
wcd_gpio_direction_output() for consistency with the rest of the code
and propagate any errors.

Link: https://lore.kernel.org/r/20250709-gpiochip-set-rv-gpio-remaining-v1-2-b8950f69618d@linaro.org


Signed-off-by: default avatarBartosz Golaszewski <bartosz.golaszewski@linaro.org>
parent db12cdc8

drivers/gpio/gpio-wcd934x.c

+5 −2
Original line number Diff line number Diff line
@@ -46,9 +46,12 @@ static int wcd_gpio_direction_output(struct gpio_chip *chip, unsigned int pin, 
				     int val)

{

	struct wcd_gpio_data *data = gpiochip_get_data(chip);

	int ret;



	regmap_update_bits(data->map, WCD_REG_DIR_CTL_OFFSET,

	ret = regmap_update_bits(data->map, WCD_REG_DIR_CTL_OFFSET,

				 WCD_PIN_MASK(pin), WCD_PIN_MASK(pin));

	if (ret)

		return ret;



	return regmap_update_bits(data->map, WCD_REG_VAL_CTL_OFFSET,

				  WCD_PIN_MASK(pin),