Commit ff3669a7 authored by Zenghui Yu's avatar Zenghui Yu Committed by Thomas Gleixner
Browse files

irqchip/alpine-msi: Fix off-by-one in allocation error path 



When alpine_msix_gic_domain_alloc() fails, there is an off-by-one in the
number of interrupts to be freed.

Fix it by passing the number of successfully allocated interrupts, instead
of the relative index of the last allocated one.

Fixes: 3841245e ("irqchip/alpine-msi: Fix freeing of interrupts on allocation error path")
Signed-off-by: default avatarZenghui Yu <yuzenghui@huawei.com>
Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/r/20240327142305.1048-1-yuzenghui@huawei.com
parent 14ced475

drivers/irqchip/irq-alpine-msi.c

+1 −1
Original line number Diff line number Diff line
@@ -165,7 +165,7 @@ static int alpine_msix_middle_domain_alloc(struct irq_domain *domain, 
	return 0;



err_sgi:

	irq_domain_free_irqs_parent(domain, virq, i - 1);

	irq_domain_free_irqs_parent(domain, virq, i);

	alpine_msix_free_sgi(priv, sgi, nr_irqs);

	return err;

}