mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/netfilter/nf.git
synced 2026-04-23 08:56:35 -04:00
099593a281
In the function drm_gem_fb_init_with_funcs, the framebuffer (fb)
and its corresponding object ID have already been registered.
So we need to cleanup the drm framebuffer if the subsequent
execution of drm_gem_fb_afbc_init fails.
Directly call drm_framebuffer_put to ensure that all fb related
resources are cleanup.
Fixes: 7707f7227f ("drm/rockchip: Add support for afbc")
Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
Link: https://lore.kernel.org/r/20250509031607.2542187-1-andyshrk@163.com
89 lines
2.3 KiB
C
89 lines
2.3 KiB
C
// SPDX-License-Identifier: GPL-2.0-only
|
|
/*
|
|
* Copyright (C) Rockchip Electronics Co., Ltd.
|
|
* Author:Mark Yao <mark.yao@rock-chips.com>
|
|
*/
|
|
|
|
#include <linux/kernel.h>
|
|
|
|
#include <drm/drm.h>
|
|
#include <drm/drm_atomic.h>
|
|
#include <drm/drm_damage_helper.h>
|
|
#include <drm/drm_fourcc.h>
|
|
#include <drm/drm_framebuffer.h>
|
|
#include <drm/drm_gem_framebuffer_helper.h>
|
|
#include <drm/drm_probe_helper.h>
|
|
|
|
#include "rockchip_drm_drv.h"
|
|
#include "rockchip_drm_fb.h"
|
|
#include "rockchip_drm_gem.h"
|
|
|
|
static const struct drm_framebuffer_funcs rockchip_drm_fb_funcs = {
|
|
.destroy = drm_gem_fb_destroy,
|
|
.create_handle = drm_gem_fb_create_handle,
|
|
.dirty = drm_atomic_helper_dirtyfb,
|
|
};
|
|
|
|
static const struct drm_mode_config_helper_funcs rockchip_mode_config_helpers = {
|
|
.atomic_commit_tail = drm_atomic_helper_commit_tail_rpm,
|
|
};
|
|
|
|
static struct drm_framebuffer *
|
|
rockchip_fb_create(struct drm_device *dev, struct drm_file *file,
|
|
const struct drm_mode_fb_cmd2 *mode_cmd)
|
|
{
|
|
struct drm_afbc_framebuffer *afbc_fb;
|
|
const struct drm_format_info *info;
|
|
int ret;
|
|
|
|
info = drm_get_format_info(dev, mode_cmd);
|
|
if (!info)
|
|
return ERR_PTR(-ENOMEM);
|
|
|
|
afbc_fb = kzalloc(sizeof(*afbc_fb), GFP_KERNEL);
|
|
if (!afbc_fb)
|
|
return ERR_PTR(-ENOMEM);
|
|
|
|
ret = drm_gem_fb_init_with_funcs(dev, &afbc_fb->base, file, mode_cmd,
|
|
&rockchip_drm_fb_funcs);
|
|
if (ret) {
|
|
kfree(afbc_fb);
|
|
return ERR_PTR(ret);
|
|
}
|
|
|
|
if (drm_is_afbc(mode_cmd->modifier[0])) {
|
|
ret = drm_gem_fb_afbc_init(dev, mode_cmd, afbc_fb);
|
|
if (ret) {
|
|
drm_framebuffer_put(&afbc_fb->base);
|
|
return ERR_PTR(ret);
|
|
}
|
|
}
|
|
|
|
return &afbc_fb->base;
|
|
}
|
|
|
|
static const struct drm_mode_config_funcs rockchip_drm_mode_config_funcs = {
|
|
.fb_create = rockchip_fb_create,
|
|
.atomic_check = drm_atomic_helper_check,
|
|
.atomic_commit = drm_atomic_helper_commit,
|
|
};
|
|
|
|
void rockchip_drm_mode_config_init(struct drm_device *dev)
|
|
{
|
|
dev->mode_config.min_width = 0;
|
|
dev->mode_config.min_height = 0;
|
|
|
|
/*
|
|
* set max width and height as default value(4096x4096).
|
|
* this value would be used to check framebuffer size limitation
|
|
* at drm_mode_addfb().
|
|
*/
|
|
dev->mode_config.max_width = 4096;
|
|
dev->mode_config.max_height = 4096;
|
|
|
|
dev->mode_config.funcs = &rockchip_drm_mode_config_funcs;
|
|
dev->mode_config.helper_private = &rockchip_mode_config_helpers;
|
|
|
|
dev->mode_config.normalize_zpos = true;
|
|
}
|