Files
linux-nf/include/linux
Jonathan Davies cf9acc90c8 net: virtio_net_hdr_to_skb: count transport header in UFO
virtio_net_hdr_to_skb does not set the skb's gso_size and gso_type
correctly for UFO packets received via virtio-net that are a little over
the GSO size. This can lead to problems elsewhere in the networking
stack, e.g. ovs_vport_send dropping over-sized packets if gso_size is
not set.

This is due to the comparison

  if (skb->len - p_off > gso_size)

not properly accounting for the transport layer header.

p_off includes the size of the transport layer header (thlen), so
skb->len - p_off is the size of the TCP/UDP payload.

gso_size is read from the virtio-net header. For UFO, fragmentation
happens at the IP level so does not need to include the UDP header.

Hence the calculation could be comparing a TCP/UDP payload length with
an IP payload length, causing legitimate virtio-net packets to have
lack gso_type/gso_size information.

Example: a UDP packet with payload size 1473 has IP payload size 1481.
If the guest used UFO, it is not fragmented and the virtio-net header's
flags indicate that it is a GSO frame (VIRTIO_NET_HDR_GSO_UDP), with
gso_size = 1480 for an MTU of 1500.  skb->len will be 1515 and p_off
will be 42, so skb->len - p_off = 1473.  Hence the comparison fails, and
shinfo->gso_size and gso_type are not set as they should be.

Instead, add the UDP header length before comparing to gso_size when
using UFO. In this way, it is the size of the IP payload that is
compared to gso_size.

Fixes: 6dd912f826 ("net: check untrusted gso_size at kernel entry")
Signed-off-by: Jonathan Davies <jonathan.davies@nutanix.com>
Reviewed-by: Willem de Bruijn <willemb@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2021-11-17 14:50:45 +00:00
..
2021-09-02 22:49:16 +02:00
2021-09-20 12:43:34 +01:00
2021-08-29 14:47:42 +03:00
2021-10-07 16:51:57 +02:00
2021-10-18 14:43:23 -06:00
2021-09-08 15:32:35 -07:00
2021-10-25 12:01:14 +05:30
2021-08-26 15:32:28 -04:00
2021-07-27 11:00:36 +02:00
2021-09-06 07:20:56 -04:00
2021-07-26 15:09:44 +02:00
2021-07-27 20:11:45 +01:00
2021-07-27 20:11:44 +01:00
2021-10-18 07:49:38 -04:00
2021-08-05 11:46:42 +01:00
2021-10-05 06:54:16 -05:00
2021-07-27 17:05:06 +01:00
2021-10-18 07:49:39 -04:00
2021-09-30 12:46:44 -06:00
2021-09-27 09:27:29 -04:00
2021-11-06 14:08:17 -07:00
2021-08-23 13:19:12 +02:00
2021-09-21 13:44:55 -07:00
2021-09-27 09:27:31 -04:00
2021-09-17 13:52:17 +01:00
2021-10-18 07:49:39 -04:00
2021-09-27 09:27:29 -04:00
2021-09-27 17:00:21 +02:00
2021-10-14 13:29:18 +02:00
2021-08-18 22:08:24 +02:00
2021-10-07 16:51:57 +02:00
2021-10-18 07:49:39 -04:00
2021-10-18 17:20:50 +02:00
2021-08-17 17:50:51 +02:00
2021-10-30 16:37:28 +02:00
2021-11-06 13:30:43 -07:00
2021-10-26 14:58:45 +01:00
2021-08-06 13:41:48 -07:00
2021-08-19 09:02:55 +09:00
2021-11-03 11:41:25 -07:00
2021-10-07 13:51:11 +02:00
2021-09-22 16:59:13 +02:00
2021-09-08 15:32:35 -07:00
2021-08-11 06:44:24 -04:00
2021-10-19 23:44:30 +08:00