git
/
linux
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

libbpf: Fix warning in calloc() usage 

When compiling libbpf with some compilers, this warning is triggered:

libbpf.c: In function ‘bpf_object__gen_loader’:
libbpf.c:9209:28: error: ‘calloc’ sizes specified with ‘sizeof’ in the earlier argument and not in the later argument [-Werror=calloc-transposed-args]
 9209 |         gen = calloc(sizeof(*gen), 1);
      |                            ^
libbpf.c:9209:28: note: earlier argument should specify number of elements, later size of each element

Fix this by inverting the calloc() arguments.

Signed-off-by: Matteo Croce <teknoraver@meta.com>
Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
Acked-by: Yonghong Song <yonghong.song@linux.dev>
Link: https://lore.kernel.org/bpf/20250717200337.49168-1-technoboy85@gmail.com
This commit is contained in:
Matteo Croce 2025-07-17 22:03:37 +02:00 committed by Andrii Nakryiko
parent 0768e980fe
commit 0ee30d937c
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tools/lib/bpf/libbpf.c
View File

@ -9210,7 +9210,7 @@ int bpf_object__gen_loader(struct bpf_object *obj, struct gen_loader_opts *opts)
return libbpf_err(-EFAULT); return libbpf_err(-EFAULT);
if (!OPTS_VALID(opts, gen_loader_opts)) if (!OPTS_VALID(opts, gen_loader_opts))
return libbpf_err(-EINVAL); return libbpf_err(-EINVAL);
gen = calloc(sizeof(*gen), 1); gen = calloc(1, sizeof(*gen));
if (!gen) if (!gen)
return libbpf_err(-ENOMEM); return libbpf_err(-ENOMEM);
gen->opts = opts; gen->opts = opts;