git
/
linux
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

rtc: ds2404: drop needless struct ds2404::rtc member 

The memory pointed to by the ::rtc member is managed via devres, and
no code in this driver uses it past _probe().

We can drop it from the structure and just use a local temporary
variable, reducing runtime memory consumption by a few bytes.

Signed-off-by: André Draszik <andre.draszik@linaro.org>
Link: https://lore.kernel.org/r/20250304-rtc-cleanups-v2-4-d4689a71668c@linaro.org
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
This commit is contained in:
André Draszik 2025-03-04 17:05:32 +00:00 committed by Alexandre Belloni
parent d19111dff9
commit 1b625aaf33
1 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
drivers/rtc/rtc-ds2404.c
View File

@ -31,7 +31,6 @@ struct ds2404 {
struct gpio_desc *rst_gpiod; struct gpio_desc *rst_gpiod;
struct gpio_desc *clk_gpiod; struct gpio_desc *clk_gpiod;
struct gpio_desc *dq_gpiod; struct gpio_desc *dq_gpiod;
struct rtc_device *rtc;
}; };
static int ds2404_gpio_map(struct ds2404 *chip, struct platform_device *pdev) static int ds2404_gpio_map(struct ds2404 *chip, struct platform_device *pdev)
@ -182,6 +181,7 @@ static const struct rtc_class_ops ds2404_rtc_ops = {
static int rtc_probe(struct platform_device *pdev) static int rtc_probe(struct platform_device *pdev)
{ {
struct ds2404 *chip; struct ds2404 *chip;
struct rtc_device *rtc;
int retval = -EBUSY; int retval = -EBUSY;
chip = devm_kzalloc(&pdev->dev, sizeof(struct ds2404), GFP_KERNEL); chip = devm_kzalloc(&pdev->dev, sizeof(struct ds2404), GFP_KERNEL);
@ -190,9 +190,9 @@ static int rtc_probe(struct platform_device *pdev)
chip->dev = &pdev->dev; chip->dev = &pdev->dev;
chip->rtc = devm_rtc_allocate_device(&pdev->dev); rtc = devm_rtc_allocate_device(&pdev->dev);
if (IS_ERR(chip->rtc)) if (IS_ERR(rtc))
return PTR_ERR(chip->rtc); return PTR_ERR(rtc);
retval = ds2404_gpio_map(chip, pdev); retval = ds2404_gpio_map(chip, pdev);
if (retval) if (retval)
@ -200,10 +200,10 @@ static int rtc_probe(struct platform_device *pdev)
platform_set_drvdata(pdev, chip); platform_set_drvdata(pdev, chip);
chip->rtc->ops = &ds2404_rtc_ops; rtc->ops = &ds2404_rtc_ops;
chip->rtc->range_max = U32_MAX; rtc->range_max = U32_MAX;
retval = devm_rtc_register_device(chip->rtc); retval = devm_rtc_register_device(rtc);
if (retval) if (retval)
return retval; return retval;