git
/
gcc
mirror of git://gcc.gnu.org/git/gcc.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

libstdc++: Fix error reporting for filesystem::rename on Windows [PR122726] 

Use the __last_system_error() function and the system_category to
convert the Windows error to a generic one.

libstdc++-v3/ChangeLog:

	PR libstdc++/122726
	* src/filesystem/ops-common.h [_GLIBCXX_FILESYSTEM_IS_WINDOWS]
	(rename): Use __last_system_error to set errno accurately.
	* testsuite/27_io/filesystem/operations/rename.cc: Test
	error_code matches errc::no_such_file_or_directory.
This commit is contained in:
Jonathan Wakely 2025-11-17 21:01:33 +00:00
parent 61f154cfe1
commit 77278e0292
2 changed files with 11 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
libstdc++-v3/src/filesystem/ops-common.h
View File

@ -159,10 +159,7 @@ namespace __gnu_posix
if (MoveFileExW(oldname, newname,
MOVEFILE_REPLACE_EXISTING | MOVEFILE_COPY_ALLOWED))
return 0;
if (GetLastError() == ERROR_ACCESS_DENIED)
errno = EACCES;
else
errno = EIO;
errno = std::__last_system_error().default_error_condition().value();
return -1;
}

10
libstdc++-v3/testsuite/27_io/filesystem/operations/rename.cc
View File

@ -170,10 +170,20 @@ test_directories()
fs::remove_all(dir, ec);
}
void
test_pr122726()
{
std::error_code ec;
const auto nonesuch = __gnu_test::nonexistent_path();
fs::rename(nonesuch, "new-name", ec);
VERIFY( ec == std::make_error_code(std::errc::no_such_file_or_directory) );
}
int
main()
{
test01();
test_symlinks();
test_directories();
test_pr122726();
}