git/linux-cryptodev-2.6
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git synced 2026-04-18 03:23:53 -04:00
Code Issues Packages Projects Releases Wiki Activity

net: core: neighbour: Reorder netlink & internal notification

Browse Source 
The netlink message needs to be send inside the critical section where the
neighbor is changed, so that it reflects the notified-upon neighbor state.
On the other hand, there is no such need in case of notifier chain: the
listeners do not assume lock, and often in fact just schedule a delayed
work to act on the neighbor later. At least one in fact also takes the
neighbor lock.

This requires that the netlink notification be done before the internal
notifier chain message is sent. That is safe to do, because the current
listeners, as well as __neigh_notify(), only read the updated neighbor
fields, and never modify them. (Apart from locking.)

Signed-off-by: Petr Machata <petrm@nvidia.com>
Reviewed-by: Ido Schimmel <idosch@nvidia.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/f3ef74d5460f14c4d102b8a5857d4a6624da9a5a.1769012464.git.petrm@nvidia.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
This commit is contained in:
Petr Machata
2026-01-21 17:43:40 +01:00
committed by Jakub Kicinski
parent a228a7e681
commit 795258891c
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
net/core/neighbour.c
View File

@@ -1187,8 +1187,8 @@ out:
}
if (notify) {
call_netevent_notifiers(NETEVENT_NEIGH_UPDATE, neigh);
neigh_notify(neigh, RTM_NEWNEIGH, 0, 0);
call_netevent_notifiers(NETEVENT_NEIGH_UPDATE, neigh);
}
trace_neigh_timer_handler(neigh, 0);
@@ -1523,8 +1523,8 @@ out:
neigh_update_managed_list(neigh);
if (notify) {
call_netevent_notifiers(NETEVENT_NEIGH_UPDATE, neigh);
neigh_notify(neigh, RTM_NEWNEIGH, 0, nlmsg_pid);
call_netevent_notifiers(NETEVENT_NEIGH_UPDATE, neigh);
}
trace_neigh_update_done(neigh, err);