Commit 01fc2215 authored by Vladimir Oltean's avatar Vladimir Oltean Committed by Vinod Koul
Browse files

dt-bindings: phy-common-props: ensure protocol-names are unique 

Rob Herring points out that "The default for .*-names is the entries
don't have to be unique.":
https://lore.kernel.org/linux-phy/20251204155219.GA1533839-robh@kernel.org/

Let's use uniqueItems: true to make sure the schema enforces this. It
doesn't make sense in this case to have duplicate properties for the
same SerDes protocol.

Note that this can only be done with the $defs + $ref pattern as
established by the previous commit. When the tx-p2p-microvolt-names
constraints were expressed directly under "properties", it would have
been validated by the string-array meta-schema, which does not support
the 'uniqueItems' keyword as can be seen below.

properties:tx-p2p-microvolt-names: Additional properties are not allowed ('uniqueItems' was unexpected)
        from schema $id: http://devicetree.org/meta-schemas/string-array.yaml



Suggested-by: default avatarRob Herring <robh@kernel.org>
Signed-off-by: default avatarVladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: default avatarRob Herring (Arm) <robh@kernel.org>
Link: https://patch.msgid.link/20260111093940.975359-4-vladimir.oltean@nxp.com


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent 33c79865

Documentation/devicetree/bindings/phy/phy-common-props.yaml

+1 −0
Original line number Diff line number Diff line
@@ -21,6 +21,7 @@ $defs: 
      'default' is not provided, the system should use manufacturer default value.

    minItems: 1

    maxItems: 16

    uniqueItems: true

    items:

      enum:

        - default