Commit 0341d1b1 authored by Nathan Chancellor's avatar Nathan Chancellor Committed by Linus Walleij
Browse files

pinctrl: airoha: Fix AIROHA_PINCTRL_CONFS_DRIVE_E2 in an7583_pinctrl_match_data 

Clang warns (or errors with CONFIG_WERROR=y / W=e):

  pinctrl/mediatek/pinctrl-airoha.c:2064:41: error: variable 'an7583_pinctrl_drive_e2_conf' is not needed and will not be emitted [-Werror,-Wunneeded-internal-declaration]
   2064 | static const struct airoha_pinctrl_conf an7583_pinctrl_drive_e2_conf[] = {
        |                                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~

Due to a typo, an7583_pinctrl_drive_e2_conf is only used within
ARRAY_SIZE() (hence no instance of -Wunused-variable), which is
evaluated at compile time, so it will not be needed in the final object
file.

Fix the .confs assignment for AIROHA_PINCTRL_CONFS_DRIVE_E2 in
an7583_pinctrl_match_data to clear up the warning.

Closes: https://github.com/ClangBuiltLinux/linux/issues/2142


Fixes: 3ffeb17a ("pinctrl: airoha: add support for Airoha AN7583 PINs")
Signed-off-by: default avatarNathan Chancellor <nathan@kernel.org>
Acked-by: default avatarChristian Marangi <ansuelsmth@gmail.com>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent f2bd5a0f

drivers/pinctrl/mediatek/pinctrl-airoha.c

+1 −1
Original line number Diff line number Diff line
@@ -2993,7 +2993,7 @@ static const struct airoha_pinctrl_match_data an7583_pinctrl_match_data = { 
			.num_confs = ARRAY_SIZE(an7583_pinctrl_pulldown_conf),

		},

		[AIROHA_PINCTRL_CONFS_DRIVE_E2] = {

			.confs = en7581_pinctrl_drive_e2_conf,

			.confs = an7583_pinctrl_drive_e2_conf,

			.num_confs = ARRAY_SIZE(an7583_pinctrl_drive_e2_conf),

		},

		[AIROHA_PINCTRL_CONFS_DRIVE_E4] = {