Commit 048ce48c authored by Clay King's avatar Clay King Committed by Alex Deucher
Browse files

drm/amd/display: Incorrect 'not' operator usage 



Consolidating multiple CodeQL Fixes for alerts with rule id: cpp/incorrect-not-operator-usage

Reviewed-by: default avatarJoshua Aberback <joshua.aberback@amd.com>
Signed-off-by: default avatarClay King <clayking@amd.com>
Signed-off-by: default avatarAurabindo Pillai <aurabindo.pillai@amd.com>
Tested-by: default avatarDan Wheeler <daniel.wheeler@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 9ec77e3a

drivers/gpu/drm/amd/display/dc/dce/dce_i2c_hw.c

+1 −1
Original line number Diff line number Diff line
@@ -591,7 +591,7 @@ static bool dce_i2c_hw_engine_submit_payload(struct dce_i2c_hw *dce_i2c_hw, 
			DCE_I2C_TRANSACTION_ACTION_I2C_WRITE;





	request.address = (uint8_t) ((payload->address << 1) | !payload->write);

	request.address = (uint8_t) ((payload->address << 1) | (payload->write ? 0 : 1));

	request.length = payload->length;

	request.data = payload->data;

drivers/gpu/drm/amd/display/dc/dce/dce_i2c_sw.c

+1 −1
Original line number Diff line number Diff line
@@ -451,7 +451,7 @@ static bool dce_i2c_sw_engine_submit_payload(struct dce_i2c_sw *engine, 
			DCE_I2C_TRANSACTION_ACTION_I2C_WRITE_MOT :

			DCE_I2C_TRANSACTION_ACTION_I2C_WRITE;



	request.address = (uint8_t) ((payload->address << 1) | !payload->write);

	request.address = (uint8_t) ((payload->address << 1) | (payload->write ? 0 : 1));

	request.length = payload->length;

	request.data = payload->data;

drivers/gpu/drm/amd/display/dc/dml/dcn20/display_rq_dlg_calc_20.c

+1 −1
Original line number Diff line number Diff line
@@ -646,7 +646,7 @@ static void get_meta_and_pte_attr(struct display_mode_lib *mode_lib, 


	// the dpte_group_bytes is reduced for the specific case of vertical

	// access of a tile surface that has dpte request of 8x1 ptes.

	if (!surf_linear & (log2_dpte_req_height_ptes == 0) & surf_vert) //reduced, in this case, will have page fault within a group

	if (!surf_linear && (log2_dpte_req_height_ptes == 0) && surf_vert) //reduced, in this case, will have page fault within a group

		rq_sizing_param->dpte_group_bytes = 512;

	else

		//full size

drivers/gpu/drm/amd/display/dc/dml/dcn20/display_rq_dlg_calc_20v2.c

+1 −1
Original line number Diff line number Diff line
@@ -646,7 +646,7 @@ static void get_meta_and_pte_attr(struct display_mode_lib *mode_lib, 


	// the dpte_group_bytes is reduced for the specific case of vertical

	// access of a tile surface that has dpte request of 8x1 ptes.

	if (!surf_linear & (log2_dpte_req_height_ptes == 0) & surf_vert) //reduced, in this case, will have page fault within a group

	if (!surf_linear && (log2_dpte_req_height_ptes == 0) && surf_vert) //reduced, in this case, will have page fault within a group

		rq_sizing_param->dpte_group_bytes = 512;

	else

		//full size

drivers/gpu/drm/amd/display/dc/dml/dcn21/display_rq_dlg_calc_21.c

+1 −1
Original line number Diff line number Diff line
@@ -652,7 +652,7 @@ static void get_meta_and_pte_attr( 
	if (hostvm_enable)

		rq_sizing_param->dpte_group_bytes = 512;

	else {

		if (!surf_linear & (log2_dpte_req_height_ptes == 0) & surf_vert) //reduced, in this case, will have page fault within a group

		if (!surf_linear && (log2_dpte_req_height_ptes == 0) && surf_vert) //reduced, in this case, will have page fault within a group

			rq_sizing_param->dpte_group_bytes = 512;

		else

			//full size