Commit 052bd11e authored by Thomas Weißschuh's avatar Thomas Weißschuh Committed by Greg Kroah-Hartman
Browse files

misc: eeprom/max6875: Constify 'struct bin_attribute' 



The sysfs core now allows instances of 'struct bin_attribute' to be
moved into read-only memory. Make use of that to protect them against
accidental or malicious modifications.

Signed-off-by: default avatarThomas Weißschuh <linux@weissschuh.net>
Link: https://lore.kernel.org/r/20241221-sysfs-const-bin_attr-misc-drivers-v2-8-ba5e79fe8771@weissschuh.net


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 6a43faaa

drivers/misc/eeprom/max6875.c

+2 −2
Original line number Diff line number Diff line
@@ -104,7 +104,7 @@ static void max6875_update_slice(struct i2c_client *client, int slice) 
}



static ssize_t max6875_read(struct file *filp, struct kobject *kobj,

			    struct bin_attribute *bin_attr,

			    const struct bin_attribute *bin_attr,

			    char *buf, loff_t off, size_t count)

{

	struct i2c_client *client = kobj_to_i2c_client(kobj);
@@ -127,7 +127,7 @@ static const struct bin_attribute user_eeprom_attr = { 
		.mode = S_IRUGO,

	},

	.size = USER_EEPROM_SIZE,

	.read = max6875_read,

	.read_new = max6875_read,

};



static int max6875_probe(struct i2c_client *client)