Commit 6a43faaa authored by Thomas Weißschuh's avatar Thomas Weißschuh Committed by Greg Kroah-Hartman
Browse files

misc: eeprom/idt_89hpesx: Constify 'struct bin_attribute' 



The sysfs core now allows instances of 'struct bin_attribute' to be
moved into read-only memory. Make use of that to protect them against
accidental or malicious modifications.

Signed-off-by: default avatarThomas Weißschuh <linux@weissschuh.net>
Link: https://lore.kernel.org/r/20241221-sysfs-const-bin_attr-misc-drivers-v2-7-ba5e79fe8771@weissschuh.net


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent e588522d

drivers/misc/eeprom/idt_89hpesx.c

+3 −3
Original line number Diff line number Diff line
@@ -847,7 +847,7 @@ static int idt_csr_read(struct idt_89hpesx_dev *pdev, u16 csraddr, u32 *data) 
 * @count:	Number of bytes to write

 */

static ssize_t eeprom_write(struct file *filp, struct kobject *kobj,

			    struct bin_attribute *attr,

			    const struct bin_attribute *attr,

			    char *buf, loff_t off, size_t count)

{

	struct idt_89hpesx_dev *pdev;
@@ -871,7 +871,7 @@ static ssize_t eeprom_write(struct file *filp, struct kobject *kobj, 
 * @count:	Number of bytes to write

 */

static ssize_t eeprom_read(struct file *filp, struct kobject *kobj,

			   struct bin_attribute *attr,

			   const struct bin_attribute *attr,

			   char *buf, loff_t off, size_t count)

{

	struct idt_89hpesx_dev *pdev;
@@ -1017,7 +1017,7 @@ static ssize_t idt_dbgfs_csr_read(struct file *filep, char __user *ubuf, 
 * NOTE Size will be changed in compliance with OF node. EEPROM attribute will

 * be read-only as well if the corresponding flag is specified in OF node.

 */

static BIN_ATTR_RW(eeprom, EEPROM_DEF_SIZE);

static const BIN_ATTR_RW(eeprom, EEPROM_DEF_SIZE);



/*

 * csr_dbgfs_ops - CSR debugfs-node read/write operations