Commit 07e23c14 authored by Adrian Hunter's avatar Adrian Hunter Committed by Ulf Hansson
Browse files

mmc: bcm2835: Replace kmap_atomic() with kmap_local_page() 



kmap_local_page() is equivalent to kmap_atomic() except that it does not
disable page faults or preemption. Where possible kmap_local_page() is
preferred to kmap_atomic() - refer kernel highmem documentation.

In this case, there is no need to disable page faults or preemption, so
replace kmap_atomic() with kmap_local_page(), and, correspondingly,
kunmap_atomic() with kunmap_local().

Signed-off-by: default avatarAdrian Hunter <adrian.hunter@intel.com>
Link: https://lore.kernel.org/r/20221005101951.3165-7-adrian.hunter@intel.com


Signed-off-by: default avatarUlf Hansson <ulf.hansson@linaro.org>
parent e9c97222

drivers/mmc/host/bcm2835.c

+2 −2
Original line number Diff line number Diff line
@@ -1070,7 +1070,7 @@ static void bcm2835_dma_complete_work(struct work_struct *work) 
			host->drain_page += host->drain_offset >> PAGE_SHIFT;

			host->drain_offset &= ~PAGE_MASK;

		}

		page = kmap_atomic(host->drain_page);

		page = kmap_local_page(host->drain_page);

		buf = page + host->drain_offset;



		while (host->drain_words) {
@@ -1081,7 +1081,7 @@ static void bcm2835_dma_complete_work(struct work_struct *work) 
			host->drain_words--;

		}



		kunmap_atomic(page);

		kunmap_local(page);

	}



	bcm2835_finish_data(host);